Add test for Hash#each consistently yields a 2-element array #885

JuanCrg90 · 2021-10-23T14:42:29Z

https://bugs.ruby-lang.org/issues/12706?tab=history

As a semantics, Hash#each yields a 2-element array (pairs of keys and
values). So, { a: 1 }.each(&->(k, v) { }) should raise an exception
due to lambda's arity check.

https://bugs.ruby-lang.org/issues/12706?tab=history > As a semantics, Hash#each yields a 2-element array (pairs of keys and > values). So, { a: 1 }.each(&->(k, v) { }) should raise an exception > due to lambda's arity check.

JuanCrg90 · 2021-10-27T16:04:59Z

What do you think @eregon ?

eregon · 2021-10-27T17:50:33Z

core/hash/each_spec.rb

+
+  ruby_version_is "3.0" do
+    it 'consistently yields a 2-element array' do
+      -> { { a: 1 }.each(&->(k, v) { }) }.should raise_error(ArgumentError)


Could you assert the message too? I think it'd help clarity.
Also it'd be good to test that it works fine with a lambda taking a single argument.

BTW it seems the same change applies to Hash#each_pair too, so could you move it to the core/hash/shared/each.rb shared spec?

Looks like it's already covered actually:

spec/core/hash/shared/each.rb

Lines 41 to 55 in 7376aa0

ruby_version_is "3.0" do

it "always yields an Array of 2 elements, even when given a callable of arity 2" do

obj = Object.new

def obj.foo(key, value)

end

-> {

{ "a" => 1 }.send(@method, &obj.method(:foo))

}.should raise_error(ArgumentError)

-> {

{ "a" => 1 }.send(@method, &-> key, value { })

}.should raise_error(ArgumentError)

end

end

eregon · 2021-10-27T17:53:42Z

Sorry for the late review. In the shared spec it seems already tested, so I'll close this.

Add test for Hash#each consistently yields a 2-element array

0d4ff98

https://bugs.ruby-lang.org/issues/12706?tab=history > As a semantics, Hash#each yields a 2-element array (pairs of keys and > values). So, { a: 1 }.each(&->(k, v) { }) should raise an exception > due to lambda's arity check.

eregon reviewed Oct 27, 2021

View reviewed changes

eregon closed this Oct 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for Hash#each consistently yields a 2-element array #885

Add test for Hash#each consistently yields a 2-element array #885

JuanCrg90 commented Oct 23, 2021

JuanCrg90 commented Oct 27, 2021

eregon Oct 27, 2021

eregon Oct 27, 2021

eregon Oct 27, 2021

eregon commented Oct 27, 2021

	ruby_version_is "3.0" do
	it "always yields an Array of 2 elements, even when given a callable of arity 2" do
	obj = Object.new
	def obj.foo(key, value)
	end

	-> {
	{ "a" => 1 }.send(@method, &obj.method(:foo))
	}.should raise_error(ArgumentError)

	-> {
	{ "a" => 1 }.send(@method, &-> key, value { })
	}.should raise_error(ArgumentError)
	end
	end

Add test for Hash#each consistently yields a 2-element array #885

Add test for Hash#each consistently yields a 2-element array #885

Conversation

JuanCrg90 commented Oct 23, 2021

JuanCrg90 commented Oct 27, 2021

eregon Oct 27, 2021

Choose a reason for hiding this comment

eregon Oct 27, 2021

Choose a reason for hiding this comment

eregon Oct 27, 2021

Choose a reason for hiding this comment

eregon commented Oct 27, 2021